2 hook requests :)

[alkhaef]

Hello friends.

I'd like to request a HookAddCode type of hook in "OpenDental\Forms Reports\formRpOutstandingIns.cs" in butRefresh_Click().

Code: Select all

		private void butRefresh_Click(object sender,EventArgs e) {
// PLEASE ADD HOOK HERE - NO PARAMETERS NECESSARY :-D.
			FillGrid();
		}

...and also another HookAddCode type in "OpenDentBusiness\Data Interface\Claims.cs" near the end of GetOutInsClaims().

Code: Select all

				command+="AND claim.ClaimType!='Preauth' ";
			}
			command+="ORDER BY carrier.Phone,insplan.PlanNum, carrier.Phone,insplan.PlanNum";
// PLEASE ADD HOOK HERE, AND PLEASE INCLUDE "command" IN THE PARAMETER SET :-D.
			DataTable table=Db.GetTable(command);
			return table;

Thanks a million!

[jordansparks]

Those seem fine.

[michael]

Code: Select all

Plugins.HookAddCode(null,"Claims.GetOutInsClaims_end",command);

has been added to Claims.cs and

Code: Select all

Plugins.HookAddCode(this,"FormRpOutstandingIns.butRefresh_begin");

has been added to FormRpOutstandingIns.cs.

These will be in 11.0.31 and 11.1.1 (beta).

[alkhaef]

Thanks guys!

I did notice, however, that strings in c#, although reference types, are immutable.

So for me to be able to touch the string in my plugin, we'd have to use a string builder, or do something like the following:

Code: Select all

			command+="ORDER BY carrier.Phone,insplan.PlanNum, carrier.Phone,insplan.PlanNum";
//START
			object[] paramArray = {(object)(command)};
			Plugins.HookAddCode(null, "Claims.GetOutInsClaims_beforequeryrun", paramArray);
			command = (string)(paramArray[0]);
//END
			DataTable table = Db.GetTable(command);
			return table;

[jordansparks]

Well, there's no need to explicitly create the paramArray since it uses the params keyword. So it would be more like this:

Code: Select all

object boxedCommand = command;
Plugins.HookAddCode(null, "Claims.GetOutInsClaims_beforequeryrun", boxedCommand);
command = (string)boxedCommand;

But we haven't tested that, and I'm not 100% certain that that's how strings get boxed/unboxed.

[alkhaef]

Hi Dr. Sparks,

That was what I thought (and tried) too, but it didn't seem to work. Here's what happened after the hook was invoked:

My Plugin.cs's parameter[0]: correct updated value
OD's Plugins.cs's parameter[0]: correct updated value
OD's Claims.cs's boxedCommand: incorrect original value
OD's Claims.cs's command: incorrect original value

Odd, eh? The only difference I could think of between the call to Plugins.cs's HookAddCode and the call to my plugin's HookAddCode was the pre-creation of the array, bypassing the params keyword usage.

It still doesn't make much sense to me, but rather than investigate c#'s/.net's quirks, I took the lazy-brute-force route and found something that does work - building the array oneself. If you guys end up finding a cleaner way, then all the better.

Thanks again

[jordansparks]

After testing with strings and with ints, I would like the following pattern to be used for these situations

Code: Select all

object[] parameters={command};
Plugins.HookAddCode(null, "Claims.GetOutInsClaims_beforequeryrun", parameters);
command=(string)parameters[0];

It's also been documented in the manual.

[michael]

Hook has been changed according to Jordan's specification in the head and in the beta version (11.1).