Faulty CombinePaths reference

This forum is for programmers who have questions about the source code.
Post Reply
V Suite
Posts: 136
Joined: Sun Aug 19, 2007 6:56 pm

Faulty CombinePaths reference

Post by V Suite » Sun Aug 19, 2007 7:07 pm

I'm sorry to post this as I'm sure it will be corrected quickly in the current 5.0.x SVN. The solution could not build because of a faulty reference to ODFileUtils.CombinePaths in FormCommunications.cs which tried to combine 3 strings though it can only combine two. This error broke my previous testing build.

I simply converted the triple combine in butStationary_Click to two double combines as follows:

Code: Select all

				try {
					this.Cursor = Cursors.AppStarting;
					string patFolder=ODFileUtils.CombinePaths(
						FormPath.GetPreferredImagePath(),
						ODFileUtils.CombinePaths(
						     PatCur.ImageFolder.Substring(0, 1),
						     PatCur.ImageFolder)
						);
Again apologies for posting.

User avatar
jordansparks
Site Admin
Posts: 5742
Joined: Sun Jun 17, 2007 3:59 pm
Location: Salem, Oregon
Contact:

Post by jordansparks » Sun Aug 19, 2007 7:19 pm

Don't alter FormCommunications. Revert that change. The true fix has already been committed.
Jordan Sparks, DMD
http://www.opendental.com

V Suite
Posts: 136
Joined: Sun Aug 19, 2007 6:56 pm

Post by V Suite » Sun Aug 19, 2007 7:46 pm

No prob. I'm now looking at CodeBase.ODFileUtils in the current /head, and see that a second 3 argument definition for CombinePaths is there which would fix the problem. I need to redownload OD5.0 source as it should also be there now.

User avatar
jordansparks
Site Admin
Posts: 5742
Joined: Sun Jun 17, 2007 3:59 pm
Location: Salem, Oregon
Contact:

Post by jordansparks » Mon Aug 20, 2007 6:34 am

You don't need to redownload it. Just right click, Update.
Jordan Sparks, DMD
http://www.opendental.com

Post Reply